Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(GuildChannel): clone its PermissionOverwriteManager too #6083

Merged

Conversation

SpaceEEC
Copy link
Member

@SpaceEEC SpaceEEC commented Jul 9, 2021

Please describe the changes this PR makes and why it should be merged:

This PR fixes #6082 by cloning GuildChannel#permissionOverwrites when cloning the channel itself.
This PR also addresses the issue that a passed iterable would cause the then created PermissionOverwrites to be without a channel as the channel property would be initialized after the parent's constructor added them.
(This might be better solved with another private method to be called from the deriving classes, e.g. this._init(iterable); or similar)

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@iCrawl iCrawl requested review from kyranet and vladfrangu July 9, 2021 11:25
@iCrawl iCrawl added this to the Version 13 milestone Jul 9, 2021
@iCrawl iCrawl merged commit f72ce7c into discordjs:master Jul 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression: permission overwrite bits on old and new channel in channelUpdate are the same
3 participants