fix(PermissionsOverwrites): only convert type if number #6092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iCrawl
approved these changes
Jul 10, 2021
kyranet
approved these changes
Jul 10, 2021
vladfrangu
approved these changes
Jul 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
In some situations
PermissionsOverwrites#_patchwas being called with an existingPermissionsOverwritesobject rather than raw packet data from Discord (I observed this locally when an overwrite was removed from a channel). This meant thattypewas already a string, and so the enum conversion was resulting in it incorrectly being stored as a number.This PR tweaks the patch logic in
PermissionsOverwritesto ensure that the enum conversion only occurs if the data provided is a number. If it is not, it is assumed that it is already a valid string type. This ensures thatPermissionsOverwrites#typeis always actually a string, as documented.Status and versioning classification: