Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(GuildPreview): add createdAt & createdTimestamp #6130

Merged
merged 3 commits into from Jul 18, 2021
Merged

feat(GuildPreview): add createdAt & createdTimestamp #6130

merged 3 commits into from Jul 18, 2021

Conversation

GoldenAngel2
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:
GuildPreview is missing the createdAt & createdTimestamp fields since it doesn't extend the BaseGuild class, so this PR adds it.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

SpaceEEC
SpaceEEC requested changes Jul 17, 2021
View reviewed changes
Copy link
Member

@SpaceEEC SpaceEEC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

src/structures/GuildPreview.js Outdated Show resolved Hide resolved
@GoldenAngel2 @SpaceEEC
Update src/structures/GuildPreview.js
7eb2134 
Co-authored-by: SpaceEEC <spaceeec@yahoo.com>
@vladfrangu vladfrangu requested a review from SpaceEEC July 17, 2021 11:19
@iCrawl iCrawl requested a review from kyranet July 17, 2021 11:24
@iCrawl iCrawl merged commit 9f039a8 into discordjs:master Jul 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladfrangu vladfrangu vladfrangu approved these changes

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@GoldenAngel2 @vladfrangu @kyranet @SpaceEEC @iCrawl