New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: right-clickybois (context menu support for ApplicationCommand and CommandInteraction) #6176
Conversation
|
imo it's a bad idea to stick the target information into |
Friendly reminder that draft PR means not ready for review |
fc1db39
to
06f00a3
Compare
This needs a rebase. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small doc nit, otherwise LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ApplicationCommand#type
should be added so that it's possible to check whether the command is a slash command or context menu.
Right, I misread. Will do. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You forgot to update the ApplicationCommand types, otherwise LGTM!
This needs a rebase. |
Co-authored-by: SpaceEEC <spaceeec@yahoo.com>
Co-authored-by: Sugden <28943913+NotSugden@users.noreply.github.com>
This adds support for creating Application Commands in right-click context menus, and receiving the interactions.
The received data is parsed into the CommandOptionResolver as seamlessly as possible:
USER
type option:getUser('user)
/getMember('user')
_MESSAGE
type option for the newgetMessage('message')
The type of application command is yet to be included in the interaction data, but when it is this will be updated to use that rather than relying on the existence of
target_id
.Status and versioning classification: