feat(FetchRecommendedShardsOptions): account for large bot sharding #6184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J-Human
suggested changes
Jul 26, 2021
Co-authored-by: Justin <justinleeong@gmail.com>
Co-authored-by: Justin <justinleeong@gmail.com>
vladfrangu
previously requested changes
Jul 26, 2021
kyranet
approved these changes
Jul 28, 2021
iCrawl
approved these changes
Jul 28, 2021
SpaceEEC
approved these changes
Jul 28, 2021
scottbucher
referenced
this pull request
in KevinNovak/Discord-Bot-TypeScript-Template
Aug 14, 2021
* Update packages * Replace discord.js-light with discord.js * Fixes for discord.js v13 * Fix broadcastEval's * Update README * Disable commonly unused caches
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Implements the changes described in #5672. This changes Util.fetchRecommendedShards to take in a FetchRecommendedShardsOption which includes guildsPerShard which is the number of guilds per shard the user wants and a boolean largeBotSharding option which decides if discord.js will round their shards up to a multiple of 16 which is required for large bot sharding.
Status and versioning classification: