Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use string instead of Snowflake for invites #6202

Merged
merged 2 commits into from Jul 28, 2021
Merged

fix: Use string instead of Snowflake for invites #6202

merged 2 commits into from Jul 28, 2021

Conversation

Jiralite
Copy link
Member

Please describe the changes this PR makes and why it should be merged:
The typings and documentation both detailed a Snowflake to be used for GuildInviteManager#cache and GuildInviteManager#fetch() instead of a string (invite code). This pull request should resolve this!

Resolves #6199 also.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@iCrawl iCrawl merged commit f060a3f into discordjs:master Jul 28, 2021
@Jiralite Jiralite deleted the patch-1 branch July 28, 2021 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

in djs v13 Invites collections has wrong key type
5 participants