feat(ThreadChannel): add fetchOwner() method #6207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImRodry
changed the title
SpaceEEC
previously requested changes
Jul 29, 2021
Co-authored-by: SpaceEEC <spaceeec@yahoo.com>
kyranet
requested changes
Jul 29, 2021
Jiralite
requested changes
Jul 29, 2021
|
I believe the current implementation of this always expects to return the owner, but this is not true. The owner can leave! This would make the return type possibly |
Jiralite
requested changes
Jul 29, 2021
Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com>
Jiralite
approved these changes
Jul 29, 2021
vladfrangu
approved these changes
Jul 30, 2021
kyranet
approved these changes
Jul 30, 2021
iCrawl
approved these changes
Jul 31, 2021
SpaceEEC
approved these changes
Jul 31, 2021
IRONM00N
pushed a commit
to TanzaniteBot/discord.js
that referenced
this pull request
Aug 1, 2021
* feat(ThreadChannel): add owner and fetchOwner() * fix(ThreadChannel): remove owner and return ThreadMember with fetchOwner * fix(ThreadChannel): apply suggestions from code review Co-authored-by: SpaceEEC <spaceeec@yahoo.com> * fix(ThreadChannel): correctly point to the manager * docs(FetchOwnerOptions): update desc to mention threads * fix(ThreadChannel): fetchOwner can return null * docs(ThreadChannel): owner is nullable Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com> Co-authored-by: SpaceEEC <spaceeec@yahoo.com> Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
This PR adds a fetchOwner() method that returns the ThreadMember object corresponding to the Owner of the thread
Status and versioning classification: