Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(PermissionOverwrites): throw better error if resolving option fails #6219

Merged

Conversation

SpaceEEC
Copy link
Member

Please describe the changes this PR makes and why it should be merged:

This PR fixes a bug that causes invalid permission flags to be reported back as undefined
e.g.

channel.permissionOverwrites.edit(role, {
    FOO_BAR: true,
});

Would throw this error: RangeError [BITFIELD_INVALID]: Invalid bitfield flag or number: undefined.

With this PR it will throw: RangeError [BITFIELD_INVALID]: Invalid bitfield flag or number: FOO_BAR.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@iCrawl iCrawl added this to the Version 13 milestone Jul 29, 2021
@iCrawl iCrawl merged commit 42a0313 into discordjs:master Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants