Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Constants): added more error codes #6234

Merged
merged 2 commits into from Aug 3, 2021
Merged

feat(Constants): added more error codes #6234

merged 2 commits into from Aug 3, 2021

Conversation

kyranet
Copy link
Member

@kyranet kyranet commented Jul 30, 2021

Please describe the changes this PR makes and why it should be merged:

ref: discord/discord-api-docs#3542

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

@kyranet kyranet added this to the Version 13 milestone Jul 30, 2021
vladfrangu
vladfrangu approved these changes Jul 30, 2021
View reviewed changes
Copy link
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once upstream PR is merged - feel free to open one in -types too!

iCrawl
iCrawl reviewed Jul 30, 2021
View reviewed changes
src/util/Constants.js Outdated Show resolved Hide resolved
@kyranet @iCrawl
docs: removed numbers
e6c0b49 
Co-authored-by: Noel <buechler.noel@outlook.com>
@iCrawl iCrawl merged commit 6b2098f into discordjs:master Aug 3, 2021
@kyranet kyranet deleted the feat/add-more-codes-07-30 branch January 7, 2022 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iCrawl iCrawl iCrawl approved these changes

@vladfrangu vladfrangu vladfrangu approved these changes

@SpaceEEC SpaceEEC Awaiting requested review from SpaceEEC

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 13
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kyranet @vladfrangu @iCrawl