New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(StartThreadOptions): default autoArchiveDuration to channel's defaultAutoArchiveDuration #6278
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, waiting for upstream PR to be landed first.
Made |
I'm honestly not sure what to do with this PR in its current state and what seems to me like a Discord API bug. |
I think we should wait to see what the dapi maintainers say about the other PR and if the bug gets fixed. If it does I can revert the last commit |
aafd583
to
394c0f3
Compare
394c0f3
to
5f801af
Compare
6024881
to
672032b
Compare
672032b
to
8419783
Compare
Upstream PR has been merged |
Please describe the changes this PR makes and why it should be merged:
This PR marks a thread's autoArchiveDuration parameter as optional when creating one, and defaults it to the channel's defaultAutoArchiveDuration when present. Otherwise, the Discord API will default it to 24 hours as seen in the upstream PR linked below
馃寠 Upstream PR:
Status and versioning classification: