Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(WebSocketShard): mark shard ready if no guilds intent #6284

Merged
merged 2 commits into from Aug 3, 2021

Conversation

ckohen
Copy link
Member

@ckohen ckohen commented Aug 3, 2021

Please describe the changes this PR makes and why it should be merged:

Fixes a bug where the client would not emit ready despite being ready, having to wait 15 seconds instead when no guilds intent was specified

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@iCrawl iCrawl added this to the Version 13 milestone Aug 3, 2021
src/client/websocket/WebSocketShard.js Outdated Show resolved Hide resolved
src/client/websocket/WebSocketShard.js Outdated Show resolved Hide resolved
Co-Authored-By: Sugden <28943913+NotSugden@users.noreply.github.com>
@iCrawl iCrawl merged commit 09471be into discordjs:master Aug 3, 2021
@ckohen ckohen deleted the no-await-guilds branch August 4, 2021 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants