Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Collector): return a boolean on checkEnd #6289

Merged
merged 1 commit into from Aug 5, 2021

Conversation

ImRodry
Copy link
Contributor

@ImRodry ImRodry commented Aug 3, 2021

Please describe the changes this PR makes and why it should be merged:
This PR makes a small change to Collector#checkEnd to make it return a boolean representing whether or not the collector ended.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@iCrawl iCrawl added this to the Version 13 milestone Aug 3, 2021
@SpaceEEC
Copy link
Member

SpaceEEC commented Aug 4, 2021

While there probably isn't anything inherently wrong with this change, this method is mostly used internally after handling an event to maybe stop the collector.

What's the use case here? Do you have an example?

@ImRodry
Copy link
Contributor Author

ImRodry commented Aug 4, 2021

Gonna be honest I've never used this method before but I made this change because it made sense in my head that a function called "checkEnd" would return whether the collector ended or not after running that. Also adding this may make it so the function is used more? Not sure but if it's not meant to be used it can always be marked as private

@iCrawl iCrawl merged commit f473f43 into discordjs:master Aug 5, 2021
@ImRodry ImRodry deleted the feat-collector-checkend branch August 5, 2021 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants