Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Channel): add isVoice() #6297

Merged
merged 1 commit into from Aug 5, 2021
Merged

feat(Channel): add isVoice() #6297

merged 1 commit into from Aug 5, 2021

Conversation

DaStormer
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:
Adds isVoice() type guard to Channel. We already have isText() and isThread(), so it's logical to have one for voice-based channels as well.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

@iCrawl iCrawl added this to the Version 13 milestone Aug 4, 2021
@iCrawl iCrawl merged commit 5b4efd1 into discordjs:master Aug 5, 2021
@DaStormer DaStormer deleted the feat-channel-isvoice branch August 5, 2021 16:13
@DaStormer DaStormer mentioned this pull request Aug 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iCrawl iCrawl iCrawl approved these changes

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

@vladfrangu vladfrangu Awaiting requested review from vladfrangu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 13
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@DaStormer @iCrawl @kyranet @SpaceEEC