Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Message): fix thread getter #6309

Merged
merged 1 commit into from Aug 6, 2021
Merged

fix(Message): fix thread getter #6309

merged 1 commit into from Aug 6, 2021

Conversation

cjh980402
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:
For ThreadChannel, errors occur because channel.threads do not exist.
This PR fix that problem.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

For ThreadChannel, errors occur because channel.threads do not exist.
@kyranet
Copy link
Member

kyranet commented Aug 6, 2021

What's the type of this.channel when it lacks of threads?

@cjh980402
Copy link
Contributor Author

cjh980402 commented Aug 6, 2021

ThreadChannel does not have threads. So when I use code message.thread in message of ThreadChannel, then error is occured.

TypeError: Cannot read propery 'resolve' of undefined
    at Message.get thread [as thread]

@kyranet kyranet requested a review from iCrawl August 6, 2021 06:52
@kyranet kyranet added this to the Version 13 milestone Aug 6, 2021
@iCrawl iCrawl merged commit 913c9fa into discordjs:master Aug 6, 2021
@cjh980402 cjh980402 deleted the patch-1 branch August 6, 2021 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants