Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Caching): sweep archived threads in all channel caches #6312

Merged
merged 1 commit into from Aug 6, 2021

Conversation

ckohen
Copy link
Member

@ckohen ckohen commented Aug 6, 2021

Please describe the changes this PR makes and why it should be merged:

Fixes a bug in the current sweeping of caches where ThreadChannels would remain in the client and guild channel caches, only being removed from the thread channel caches.

Allows a bit more control over how thread channels are swept from these caches without triggering the process warning for overriding the channel caches.

Also fixes a minor documentation error in LimitedCollection.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)
  • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)

@iCrawl iCrawl added this to the Version 13 milestone Aug 6, 2021
Copy link
Member

@iCrawl iCrawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really liking the utility function 👍

@iCrawl iCrawl merged commit 3725dca into discordjs:master Aug 6, 2021
@ckohen ckohen deleted the fix-thread-caching branch August 6, 2021 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants