Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Message): handle fetched messages #6325

Merged
merged 1 commit into from Aug 7, 2021

Conversation

almostSouji
Copy link
Member

Please describe the changes this PR makes and why it should be merged:

PR #6271 has introduced a regression, because fetched messages do not include a guild_id property in the rest response. This causes Message#guild to become null for fetched messages, even if they were fetched from a guild channel.

  • try to assign the guild id from the channel, if available
  • adapt the Message#guild getter to also return the guild from the Message#channel getter, if necessary and available

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@iCrawl iCrawl merged commit ceae596 into discordjs:main Aug 7, 2021
@almostSouji almostSouji deleted the fix-msg-guild branch August 7, 2021 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants