Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(GuildMemberManager): refactor fetchMany #6328

Merged
merged 1 commit into from Aug 7, 2021

Conversation

iCrawl
Copy link
Member

@iCrawl iCrawl commented Aug 6, 2021

Please describe the changes this PR makes and why it should be merged:

Refactors / Fixes the _fetchMany function in a non-breaking but also non-stupid way to actually work as intended (since this is not a REST endpoint either).

Reasons why this is non-breaking:
The functionality before was inherently broken and could not be relied on in anyway shape or form in the first place.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@iCrawl iCrawl added this to the Version 13.1 milestone Aug 6, 2021
@iCrawl iCrawl merged commit 909c873 into main Aug 7, 2021
@iCrawl iCrawl deleted the fix/guild-members-fetch-many branch August 7, 2021 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants