Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Constants): fix CDN endpoint typings #6332

Merged
merged 1 commit into from Aug 8, 2021

Conversation

advaith1
Copy link
Contributor

@advaith1 advaith1 commented Aug 7, 2021

Please describe the changes this PR makes and why it should be merged:
CDN typings had a surprising number of issues so this fixes them:

  • DefaultAvatar takes "discriminator" (number), not id
  • a few used userId when they were not for users
  • added dynamic option to Avatar and Icon (pulled from the banner prs)
  • a bunch of id args were typed as Snowflake | number for some reason, changed those to just Snowflake
  • some methods actually take format and size in an object (for some reason) but they were typed as separate args

also changes clientId to appId to reflect Discord now using "application id" in non-OAuth2 contexts

Status and versioning classification:

  • This PR only includes non-code changes, like changes to documentation, README, etc.

@iCrawl iCrawl changed the title types(Constants): fix CDN endpoint typings fix(Constants): fix CDN endpoint typings Aug 7, 2021
@iCrawl iCrawl merged commit 47d2ef3 into discordjs:main Aug 8, 2021
@advaith1 advaith1 deleted the fix-cdn-typings branch August 8, 2021 11:45
@discordjs discordjs deleted a comment from Esmking Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants