Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CommandInteractionResolvedData): access to "raw" resolved data #6384

Merged
merged 7 commits into from Aug 12, 2021

Conversation

monbrey
Copy link
Member

@monbrey monbrey commented Aug 11, 2021

In the absence of a good way to expose individual resolved data as "mentions", this exposed the complete, parsed interaction.data.resolved object as a number of Collections, similar to how MessageMentions are provided.

Aim is to do this in a non-breaking way for 13.1.0, hence using the "resolved" property name, leaving "mentions" available if we want to do a better filtering of it somewhere else down the track.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

src/structures/CommandInteraction.js Outdated Show resolved Hide resolved
typings/index.d.ts Outdated Show resolved Hide resolved
typings/index.d.ts Outdated Show resolved Hide resolved
Co-authored-by: Sugden <28943913+NotSugden@users.noreply.github.com>
@iCrawl iCrawl merged commit fff887b into discordjs:main Aug 12, 2021
@monbrey monbrey deleted the expose-resolved branch August 15, 2021 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants