Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(WidgetMember): Default to null and not undefined #6399

Merged
merged 1 commit into from Aug 12, 2021

Conversation

Jiralite
Copy link
Member

@Jiralite Jiralite commented Aug 12, 2021

Please describe the changes this PR makes and why it should be merged:
The WidgetMember class had a bunch of properties that would default to undefined if said member was not in voice or did not have an activity. The documentation already assumed them to be nullable, but the typings didn't! Side note: WidgetMember#avatar typings were wrong as they return null if not found.

I've defaulted them now to null. The JSDocs are already nullable, so no change there. The typings have been updated from them being optional properties to nullable.

I believe the linter modified the typings file, so that went in here as well.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@iCrawl iCrawl added this to the Version 13.1 milestone Aug 12, 2021
@iCrawl iCrawl added the typings label Aug 12, 2021
@iCrawl iCrawl merged commit 44bbfa5 into discordjs:main Aug 12, 2021
@Jiralite Jiralite deleted the widget-null branch August 12, 2021 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants