fix(Guild): preferredLocale to always be a string
#6402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iCrawl
changed the title
preferredLocale to always be a stringpreferredLocale to always be a string
iCrawl
approved these changes
Aug 12, 2021
vladfrangu
approved these changes
Aug 12, 2021
SpaceEEC
approved these changes
Aug 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
#6299 modified this to be nullable, but upon looking through Discord's documentation (and all prior versions) with testing on non-community guilds, it seems it is documented to always return a string and testing has verified this. Thus, this property will be modified to be only a string!
Status and versioning classification: