Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(GuildMemberManager): add 'list' method #6403

Merged
merged 7 commits into from Aug 12, 2021
Merged

feat(GuildMemberManager): add 'list' method #6403

merged 7 commits into from Aug 12, 2021

Conversation

BenjammingKirby
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:

Add a method (list) on GuildMemberManager to support sending a request in order to list guild members

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

SpaceEEC
SpaceEEC previously requested changes Aug 12, 2021
View reviewed changes
Copy link
Member

@SpaceEEC SpaceEEC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

src/managers/GuildMemberManager.js Outdated Show resolved Hide resolved
src/managers/GuildMemberManager.js Outdated Show resolved Hide resolved
src/managers/GuildMemberManager.js Outdated Show resolved Hide resolved
vladfrangu
vladfrangu approved these changes Aug 12, 2021
View reviewed changes
Copy link
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after space's comments are resolved

BenjammingKirby and others added 3 commits August 12, 2021 10:22
@BenjammingKirby @SpaceEEC
fix(GuildMemberManager): fix jsdoc for GuildListMembersOptions' after
1265e00 
Co-authored-by: SpaceEEC <spaceeec@yahoo.com>
@BenjammingKirby @SpaceEEC
fix(GuildMemberManager): make list's parameter optional on the jsdoc
b150d11 
Co-authored-by: SpaceEEC <spaceeec@yahoo.com>
@BenjammingKirby @SpaceEEC
fix(GuildMemberManager): fix grammatical error
c3991fc 
Co-authored-by: SpaceEEC <spaceeec@yahoo.com>
@iCrawl iCrawl added this to the Version 13.1 milestone Aug 12, 2021
@iCrawl iCrawl merged commit 2bf0970 into discordjs:main Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinbioj kevinbioj kevinbioj left review comments

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl iCrawl approved these changes

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC Awaiting requested review from SpaceEEC

Assignees
No one assigned
Labels
REST semver:minor
Projects
None yet
Milestone
Version 13.1
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@BenjammingKirby @vladfrangu @kevinbioj @iCrawl @kyranet @SpaceEEC