Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(BaseClient): Remove selfbot ability #6429

Merged
merged 5 commits into from Aug 16, 2021
Merged

fix(BaseClient): Remove selfbot ability #6429

merged 5 commits into from Aug 16, 2021

Conversation

xHyroM
Copy link
Contributor

@xHyroM xHyroM commented Aug 14, 2021

Please describe the changes this PR makes and why it should be merged:

Removing this will prevent people from raiding easier. Yes they can do fork, but I don't think a well known library like this should support it.

How can you make a self bot?
new Client({_tokenType:""})

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

@xHyroM
Copy link
Contributor Author

xHyroM commented Aug 14, 2021

Alternatively, I can make it so that there will be support for bot type and bearer but I don't think it's necessary to do that and just do it this way.

Copy link
Member

@SpaceEEC SpaceEEC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a, now not needed anymore, remnant of #1883, which I think was RPC related.

@vaporoxx
Copy link
Contributor

So why not remove that parameter now that it's hard coded?

@xHyroM
Copy link
Contributor Author

xHyroM commented Aug 15, 2021

So why not remove that parameter now that it's hard coded?

Good point. I've already deleted it.

@iCrawl iCrawl added this to the Version 13.2 milestone Aug 16, 2021
@iCrawl iCrawl changed the title fix(Client, BaseClient): Remove selfbot ability fix(BaseClient): Remove selfbot ability Aug 16, 2021
@iCrawl iCrawl merged commit 9a833b1 into discordjs:main Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants