Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Util): allow empty strings in splitMessage #6437

Merged
merged 2 commits into from Aug 18, 2021
Merged

fix(Util): allow empty strings in splitMessage #6437

merged 2 commits into from Aug 18, 2021

Conversation

Markus-Rost
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:

Allow empty strings to be used in Util#splitMessage as there is not reason not to.

close #6436

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes

@iCrawl iCrawl changed the title Allow empty strings in splitMessage fix(Util): allow empty strings in splitMessage Aug 15, 2021
@Markus-Rost
Copy link
Contributor Author

I also removed the MESSAGE_CONTENT_TYPE error to use the default error of verifyString as splitMessage has no content find and the error didn't fit.

@iCrawl iCrawl merged commit d6e6244 into discordjs:main Aug 18, 2021
@iCrawl iCrawl added this to the Version 13.2 milestone Aug 23, 2021
@Markus-Rost Markus-Rost deleted the patch-1 branch October 7, 2021 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Util.splitMessage() does not allow empty strings
4 participants