Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Guild): Add Guild#maximumBitrate getter. #6455

Merged
merged 12 commits into from Aug 23, 2021
Merged

feat(Guild): Add Guild#maximumBitrate getter. #6455

merged 12 commits into from Aug 23, 2021

Conversation

fasterplayer
Copy link
Contributor

@fasterplayer fasterplayer commented Aug 16, 2021

Please describe the changes this PR makes and why it should be merged:
This PR adds a getter to Guild which indicates the maximum allowed bitrate in this guild.
This is similar to the ThreadAutoArchiveDuration['MAX'] option.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

@Jiralite
Copy link
Member

Shouldn't this be a getter?

@fasterplayer
Copy link
Contributor Author

I'll update it later today.

@fasterplayer fasterplayer changed the title feat(Guild): Add Guild#maximumBitrate property. feat(Guild): Add Guild#maximumBitrate getter. Aug 17, 2021
@fasterplayer
Copy link
Contributor Author

Shouldn't this be a getter?

Updated into a getter! Thanks for the advice. I'm new to this and trying to help the best i can!

src/structures/Guild.js Outdated Show resolved Hide resolved
src/structures/Guild.js Outdated Show resolved Hide resolved
src/structures/Guild.js Outdated Show resolved Hide resolved
fasterplayer and others added 4 commits August 16, 2021 22:21
Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com>
Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com>
src/structures/Guild.js Outdated Show resolved Hide resolved
src/structures/Guild.js Outdated Show resolved Hide resolved
src/structures/Guild.js Outdated Show resolved Hide resolved
src/structures/Guild.js Outdated Show resolved Hide resolved
fasterplayer and others added 2 commits August 17, 2021 16:36
Never used a switch like this. Nice to know!

Co-authored-by: Sugden <28943913+NotSugden@users.noreply.github.com>
src/structures/Guild.js Outdated Show resolved Hide resolved
Co-authored-by: Antonio Román <kyradiscord@gmail.com>
src/structures/Guild.js Outdated Show resolved Hide resolved
@iCrawl iCrawl merged commit 21983de into discordjs:main Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants