Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Threads): update permissions and fix getters #6466

Merged
merged 9 commits into from Oct 2, 2021
Merged

feat(Threads): update permissions and fix getters #6466

merged 9 commits into from Oct 2, 2021

Conversation

advaith1
Copy link
Contributor

@advaith1 advaith1 commented Aug 17, 2021 •
edited

Please describe the changes this PR makes and why it should be merged:

Status and versioning classification:

  • I know how to update typings and have done so, or typings don't need updating

ckohen
ckohen requested changes Aug 17, 2021
View reviewed changes
src/util/Permissions.js Outdated Show resolved Hide resolved
iCrawl
iCrawl reviewed Aug 17, 2021
View reviewed changes
src/util/Permissions.js Outdated Show resolved Hide resolved
iCrawl
iCrawl reviewed Aug 17, 2021
View reviewed changes
src/util/Permissions.js Outdated Show resolved Hide resolved
iCrawl
iCrawl reviewed Aug 17, 2021
View reviewed changes
typings/index.d.ts Outdated Show resolved Hide resolved
@iCrawl iCrawl requested a review from kyranet August 24, 2021 20:28
@iCrawl iCrawl added this to the Version 13.2 milestone Aug 25, 2021
iCrawl
iCrawl approved these changes Sep 26, 2021
View reviewed changes
Copy link
Member

@iCrawl iCrawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a rebase.

@iCrawl iCrawl merged commit 10478ad into discordjs:main Oct 2, 2021
@advaith1 advaith1 deleted the thread-permission-updates branch October 5, 2021 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckohen ckohen ckohen requested changes

@NotSugden NotSugden NotSugden left review comments

@almeidx almeidx almeidx left review comments

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl iCrawl approved these changes

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

Assignees
No one assigned
Labels
api changes permissions semver:minor threads
Projects
None yet
Milestone
Version 13.2
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@advaith1 @ckohen @vladfrangu @iCrawl @kyranet @SpaceEEC @NotSugden @almeidx