feat: export BaseCommandInteraction #6478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's the reason for exporting this one? It shouldn't ever be constructed, everything should be a subclass of it. |
|
I'm wanting to use it for polymorphic behavior. I have an Interaction, which could be any of the subclasses, but I'm only interested in accessing the properties defined in the abstract BaseCommandInteraction. I'd like to be able to run I'm working in TypeScript, and this class is exported in the type definitions which makes it appear to be usable in this way, but since it isn't exported in index.js the import is always undefined. |
vladfrangu
approved these changes
Aug 21, 2021
iCrawl
approved these changes
Aug 21, 2021
SpaceEEC
approved these changes
Aug 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
This PR adds BaseCommandInteraction to the index.js file.
This PR changes the library's interface (methods or parameters added)