feat(ThreadChannel): add fetchStarterMessage #6488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImRodry
force-pushed
the
feat-starterMessage
branch
from
13b7dfd
to
8a9519f
Compare
ImRodry
changed the title
|
After thinking about this for a while I opted by adding a method instead to be more in line with the direction the library has been going in recently. The getter was unreliable as it got the message from cache so this just simply fetches it. |
|
When can this method return |
Good point, will update |
vladfrangu
previously requested changes
Aug 21, 2021
Co-authored-by: Vlad Frangu <kingdgrizzle@gmail.com>
|
@PuneetGopinath refer to monbrey’s comment: #6488 (comment) |
Ohk. |
Nor should it be there, because fetch will either resolve to a Message, or throw. Nullish-coallescing is not correct in any sense. |
vladfrangu
approved these changes
Aug 23, 2021
SpaceEEC
approved these changes
Aug 23, 2021
kyranet
approved these changes
Aug 23, 2021
iCrawl
approved these changes
Aug 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
This PR adds a method to ThreadChannels called fetchStarterMessage that fetches the message that started the thread when this exists. I didn't find any better way to tell if a thread channel was started by a message or not so this just fetches the message with the same ID as the channel from the parent channel.
Status and versioning classification: