Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set methods for MessageActionRow and MessageSelectMenu #6490

Merged
merged 1 commit into from Aug 24, 2021

Conversation

ImRodry
Copy link
Contributor

@ImRodry ImRodry commented Aug 21, 2021

Please describe the changes this PR makes and why it should be merged:
Following the PR that added the setFields method for MessageEmbeds, this PR adds two new methods: setOptions for MessageSelectMenu and setComponents for MessageActionRow.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

Copy link
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

Copy link
Member

@SpaceEEC SpaceEEC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually missing the validation the add___ methods have 😅

@ImRodry
Copy link
Contributor Author

ImRodry commented Aug 23, 2021

This is actually missing the validation the add___ methods have 😅

No it’s not because the splice methods do that. That was something I included in the embed PR and was asked to change

Copy link
Member

@SpaceEEC SpaceEEC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops the second then.
I must have mistaken that for a plain splice. 😓

@ImRodry
Copy link
Contributor Author

ImRodry commented Aug 23, 2021

All good!

@iCrawl iCrawl merged commit fb50dd9 into discordjs:main Aug 24, 2021
@ImRodry ImRodry deleted the feat-set-methods branch August 24, 2021 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants