feat(Threads): add support for invitable in private threads #6501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImRodry
reviewed
Aug 22, 2021
SpaceEEC
reviewed
Aug 23, 2021
Co-authored-by: Rodry <38259440+ImRodry@users.noreply.github.com>
Co-authored-by: SpaceEEC <spaceeec@yahoo.com>
|
@ckohen I meant it for all properties but I’ll probably make a PR in the upcoming days to do this for everything across the lib if u don’t wanna change it now |
|
I know you meant for all properties, its not in scope for this PR |
|
Ah alright sorry, didn’t see your reply above |
vladfrangu
approved these changes
Aug 26, 2021
kyranet
approved these changes
Aug 26, 2021
thebigwolfy
approved these changes
Aug 26, 2021
iCrawl
approved these changes
Aug 27, 2021
iCrawl
reviewed
Aug 28, 2021
Co-authored-by: Noel <buechler.noel@outlook.com>
SpaceEEC
approved these changes
Aug 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Closes: #6379
Fixes a bug in typings that didn't pass the allowable thread types properly for news channels since this relies on it.
invitablefield in the thread creation endpoint does not seem to be respected at the moment, it is supported here, but the API does not utilize it, always setting true.invitablefield in thread creation endpoint is not respected discord/discord-api-docs#3700Status and versioning classification: