New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(xxxable): follow more properly with discord behavior #6551
Conversation
1f76452
to
f28178c
Compare
Which should I use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GuildChannel#permissionsFor
can return null if the member for the client user is uncached
598380f
to
22cfa15
Compare
0b6a55d
to
1df5ac6
Compare
Partial testing is here: https://github.com/tignear/discord.js-pr-6551-test/blob/master/main.test.js |
Co-authored-by: SpaceEEC <spaceeec@yahoo.com>
331e2ca
to
3328523
Compare
Please describe the changes this PR makes and why it should be merged:
In rare cases, the result returned by the current XXXable property may not return the exact result, but it will return the correct result.
However, it seems difficult to maintain this, so consider removing this property.
Cannot edit messages on channels that cannot send messages.Messages that are not system messages can be pinned.Status and versioning classification: