Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Message): pinnable returning false in non-DEFAULT messages #6585

Merged
merged 5 commits into from Sep 9, 2021
Merged

fix(Message): pinnable returning false in non-DEFAULT messages #6585

merged 5 commits into from Sep 9, 2021

Conversation

ImRodry
Copy link
Contributor

@ImRodry ImRodry commented Sep 3, 2021 •
edited

Please describe the changes this PR makes and why it should be merged:
This PR fixes a bug with Message#pinnable where it would return false if the type of message was not DEFAULT in some types that can be pinned. This PR fixes that so that it will now work on non system messages.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@iCrawl iCrawl added this to the Version 13.2 milestone Sep 5, 2021
SpaceEEC
SpaceEEC requested changes Sep 7, 2021
View reviewed changes
Copy link
Member

@SpaceEEC SpaceEEC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you have information that shows otherwise please review this PR mentioning that.

I just tested this and received an error:
DiscordAPIError: Cannot execute action on a system message (Code 50021)

@ImRodry
Copy link
Contributor Author

ImRodry commented Sep 7, 2021 •
edited

If you have information that shows otherwise please review this PR mentioning that.

I just tested this and received an error:
DiscordAPIError: Cannot execute action on a system message (Code 50021)

Totally forgot about system messages, fixed in 95c0575 @SpaceEEC

kyranet
kyranet previously requested changes Sep 7, 2021
View reviewed changes
src/structures/Message.js Outdated Show resolved Hide resolved
src/structures/Message.js Outdated Show resolved Hide resolved
NotSugden
NotSugden suggested changes Sep 7, 2021
View reviewed changes
src/structures/Message.js Outdated Show resolved Hide resolved
@ImRodry ImRodry requested a review from kyranet September 7, 2021 19:43
@ImRodry
Copy link
Contributor Author

ImRodry commented Sep 7, 2021

coding on mobile is hard

@iCrawl iCrawl merged commit 3183b11 into discordjs:main Sep 9, 2021
@ImRodry ImRodry deleted the fix-message-pinnable branch September 9, 2021 18:07
@tignear tignear mentioned this pull request Sep 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NotSugden NotSugden NotSugden requested changes

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl iCrawl approved these changes

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

Assignees
No one assigned
Labels
bug semver:patch utility
Projects
None yet
Milestone
Version 13.2
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ImRodry @vladfrangu @iCrawl @kyranet @SpaceEEC @NotSugden