Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: default values for setX boolean methods #6619

Merged
merged 1 commit into from Sep 14, 2021
Merged

feat: default values for setX boolean methods #6619

merged 1 commit into from Sep 14, 2021

Conversation

ImRodry
Copy link
Contributor

@ImRodry ImRodry commented Sep 10, 2021 •
edited

Please describe the changes this PR makes and why it should be merged:
This PR adds a default value of true for all setX methods across the library that accept a boolean. This follows the direction the library has recently been going in with #6279 and #6509.
This affects the following methods:

  • BaseGuildTextChannel#setNSFW
  • ClientUser#setAFK
  • Role#setHoist
  • Role#setMentionable
  • VoiceState#setDeaf
  • VoiceState#setMute
  • VoiceState#setRequestToSpeak
  • VoiceState#setSuppressed

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@kyranet kyranet added this to the Version 13.2 milestone Sep 10, 2021
@iCrawl iCrawl merged commit 8add4b0 into discordjs:main Sep 14, 2021
@ImRodry ImRodry deleted the default-param-set-methods branch September 14, 2021 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl iCrawl approved these changes

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC Awaiting requested review from SpaceEEC

Assignees
No one assigned
Labels
semver:minor
Projects
None yet
Milestone
Version 13.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ImRodry @vladfrangu @iCrawl @kyranet