Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for API command types in ApplicationCommandManager #6621

Merged
merged 3 commits into from Sep 23, 2021

Conversation

suneettipirneni
Copy link
Member

Please describe the changes this PR makes and why it should be merged:
Allows api types to be accepted in ApplicationCommandManager methods. This means typescript will no longer complain about type mismatches when using something like builders for example.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

src/structures/ApplicationCommand.js Outdated Show resolved Hide resolved
src/structures/ApplicationCommand.js Outdated Show resolved Hide resolved
src/managers/ApplicationCommandManager.js Outdated Show resolved Hide resolved
@iCrawl iCrawl merged commit ecd637f into discordjs:main Sep 23, 2021
@suneettipirneni suneettipirneni deleted the feature/api-command-support branch October 24, 2021 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants