feat(Integration): add missing props and fix docs/types #6623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iCrawl
reviewed
Sep 14, 2021
iCrawl
approved these changes
Sep 14, 2021
Co-authored-by: Noel <buechler.noel@outlook.com>
kyranet
approved these changes
Sep 15, 2021
vladfrangu
approved these changes
Sep 15, 2021
SpaceEEC
approved these changes
Sep 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
This PR adds a few missing properties to Integration and properly documents all the other ones. I also created an enum in Constants with the expireBehavior and a TODO comment for v14 where we will be able to change all the undefined properties to null, which is what the library does most of the time.
Also added the
Snowflake|stringredundant type union just to make it more clear that some ids can be snowflakes and others can be stringified numbers that are not IDs (only on youtube/twitch integrations)Status and versioning classification: