New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for role icons #6633
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nitpicks as I know this is still a WIP
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can't you also pass null for the role icon? if so docs should be updated
Yes u can |
New upstream PR: discord/discord-api-docs#3847 |
This is ready for review ✨ |
yeah, that's a client thing. |
Well the fact that the url property on an emoji is a getter and not a function like it is everywhere else makes it hard to add a fix for this. We could just get the png image by calling the CDN endpoint directly because that way we’d always make sure to get the first frame of the emoji |
pardon my stupidity (i was actually setting it to undefined); it works fine. well transparency is lost but yeah |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unicode_emoji is now the actual emoji, not a text name
ff2aef5
to
cd025db
Compare
This needs a rebase. |
This needs a rebase. |
Rebased 😓 |
Please describe the changes this PR makes and why it should be merged:
Starts work on role icons:
Status and versioning classification: