Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ApplicationCommand): add support for channel_types #6640

Merged
merged 4 commits into from Sep 27, 2021
Merged

feat(ApplicationCommand): add support for channel_types #6640

merged 4 commits into from Sep 27, 2021

Conversation

ckohen
Copy link
Member

@ckohen ckohen commented Sep 15, 2021

Please describe the changes this PR makes and why it should be merged:

馃殌

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

@ckohen ckohen changed the title feat(ApplciationCommand): add support for channel_types feat(ApplicationCommand): add support for channel_types Sep 15, 2021
@ckohen @ThaTiemsz
docs: fix typo
c8e8f72 
Co-Authored-By: Tiemen <ThaTiemsz@users.noreply.github.com>
@kyranet kyranet added this to the Version 13.2 milestone Sep 15, 2021
vladfrangu
vladfrangu approved these changes Sep 15, 2021
View reviewed changes
Copy link
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The warn block could use some rephrasing, but otherwise LGTM

almeidx
almeidx reviewed Sep 15, 2021
View reviewed changes
typings/index.d.ts Outdated Show resolved Hide resolved
@ckohen @NotSugden
refactor: cleaner nullish coalescing
12a5429 
Co-Authored-By: Sugden <28943913+NotSugden@users.noreply.github.com>
@suneettipirneni suneettipirneni mentioned this pull request Sep 16, 2021
Merged
@iCrawl iCrawl merged commit 3b14883 into discordjs:main Sep 27, 2021
BaumianerNiklas added a commit to BaumianerNiklas/Waddle-Bot that referenced this pull request Sep 27, 2021
@BaumianerNiklas
feat(commands): add support for channelTypes
88309c9 
* discord/discord-api-docs#3825
* discordjs/discord.js#6640
* possible because of 9bd1d25
* i should really fix these typings
@ckohen ckohen deleted the app-command-channel-types branch September 27, 2021 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThaTiemsz ThaTiemsz ThaTiemsz left review comments

@NotSugden NotSugden NotSugden left review comments

@almeidx almeidx almeidx left review comments

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl iCrawl approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

@kyranet kyranet Awaiting requested review from kyranet

Assignees
No one assigned
Labels
api support semver:minor
Projects
None yet
Milestone
Version 13.2
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@ckohen @vladfrangu @ThaTiemsz @iCrawl @SpaceEEC @NotSugden @almeidx @kyranet