fix: allow null to be passed in order to reset icon/avatar #6646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You're correct on that assumption |
iCrawl
approved these changes
Sep 15, 2021
SpaceEEC
approved these changes
Sep 19, 2021
kyranet
approved these changes
Sep 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
This PR updates documentation and typings to allow
nullas a valid value for icon/avatar of aGuild,ClientUser, andWebhook.It also fixes a bug in
ClientUser#editandGuild#editwhere theiconoption wasn't being resolved, making it impossible to set a new icon using a path to the local file.Modify Guild Docs, it seems thatsplash,discovery_splash, andbannercan also be set tonull. My test guild doesn't have those features, so I didn't add changes related to them here. It would be great if someone can confirm it.Status and versioning classification: