fix(Shard): eval promise never resolves #6649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NotSugden
reviewed
Sep 16, 2021
vladfrangu
approved these changes
Sep 17, 2021
iCrawl
approved these changes
Sep 17, 2021
SpaceEEC
approved these changes
Sep 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #6626
Please describe the changes this PR makes and why it should be merged:
Passing a function as a parameter in
Shard#eval()would return a promise that never resolves due to stringifying the function as described in the linked issue.This PR fixes that problem.
Status and versioning classification: