New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for autocomplete interactions #6672
Conversation
Do you think it would be better for I know you can also just check if an individual option is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR should also be adding support for the autocomplete parameter in ApplicationCommand.options[n]!
As for this it could probably be toggleable through a parameter like sendFull and, like one of the discussions above mentioned, the required parameter should be removed since it doesn't make much sense to be there, and should just be replaced by this one IMO |
This needs a rebase. |
This needs a rebase and got a new upstream PR: Can you double check if anything changed and make changes accordingly? |
It all looks good, I don't see any changes with it. |
This needs a new rebase btw |
The upstream PR was updated again today, and it was indicated that the recieved option values could be partial. Djs should probably also represent that. |
Interaction partial type perhaps? |
@OfficialSirH discord/discord-api-docs#3996 merged, please rebase and fix conflicts. |
@OfficialSirH I've made a PR for your branch to fix all of the type test errors: |
This reverts commit 3b2d716.
Fix: Autocomplete type tests
Please describe the changes this PR makes and why it should be merged:
Status and versioning classification: