fix(GuildEmoji): Cache restricted roles and author data #6675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladfrangu
reviewed
Sep 23, 2021
Jiralite
changed the title
vladfrangu
approved these changes
Sep 23, 2021
SpaceEEC
approved these changes
Sep 24, 2021
iCrawl
approved these changes
Sep 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Guild emojis that were restricted to roles were not being stored in discord.js over the gateway - an empty array would always be set. As such, methods like
GuildEmojiRoleManager.add()would completely wipe all other roles from the emoji (since it calls.set()from the cache which is empty), and then only add what you specified, which is bad behaviour and not intended.I believe I managed to fix this by setting the default value to the provided array. I have tested this and it works as expected.
Status and versioning classification: