New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(GuildManager): add missing types and converts #6683
Conversation
It seems it's a little more than the typings that aren't wholly correct with this.
discord.js/src/managers/GuildManager.js Lines 189 to 200 in 839974c
There is no mention of converting a provided
These were the only problems I found with |
I feel like the changes are good, but I don't know the code enough to feel comfortable saying "Yes this is good", so I will leave the judgement of approval to someone more knowledgeable in the code. |
Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com>
Mind modifying this to discord.js/src/managers/GuildManager.js Line 87 in 839974c
|
Please describe the changes this PR makes and why it should be merged:
Updated PartialChannelData at /typings/index.d.ts#L4509 to match /src/managers/GuildManager.js#L83.
Added missing converts (userLimit, rateLimitPerUser, overwrite.type) to
GuildManager#create
.Made
PartialOverwriteData.type
to takeOverwriteType
instead ofstring
.Status and versioning classification: