fix: don't patch set data with undefined #6694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyranet
approved these changes
Sep 28, 2021
iCrawl
approved these changes
Sep 28, 2021
ImRodry
force-pushed
the
fix-patch-undefined
branch
from
0527fd3
to
0ee9078
Compare
|
Rebased and decided not to apply the |
ImRodry
force-pushed
the
fix-patch-undefined
branch
from
0ee9078
to
bc1b7d7
Compare
SpaceEEC
approved these changes
Oct 3, 2021
vladfrangu
approved these changes
Oct 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
This PR fixes a bug across the entire library where some properties could be lost by calling ._patch. The diff is quite large because this fix was applied to all _patch methods on the library on all properties except ids. If you do not agree with some of the changes, feel free to leave a review and we can discuss them as I understand some of these may be redundant, but it's always better to be sure. Fixes #6688
Status and versioning classification: