New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow webhooks to fetch, edit and delete messages in threads #6695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImRodry
reviewed
Sep 26, 2021
What's the point of the client option? Why would we ever NOT want to allow this? EDIT: Okay, I missed the reason in your post, I see it now. Not a fan of that solution, its extremely monkey-patched. |
I have gone with @ckohen's desired approach. Feel free to re-review! |
ckohen
requested changes
Sep 26, 2021
SpaceEEC
approved these changes
Sep 27, 2021
kyranet
requested changes
Sep 28, 2021
Co-authored-by: Antonio Román <kyradiscord@gmail.com>
kyranet
approved these changes
Sep 28, 2021
ckohen
approved these changes
Sep 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
This will allow webhooks to fetch, edit and delete messages in threads.
Webhook#fetchMessage() unfortunately didn't already have an object for its second parameter. I would have liked to change it to what I commented here but to keep it not breaking, I instead added a new client option for webhooks that as a sort of opt-in feature flag that makes the library parse the second parameter as an object, thus allowing access to fetching a message in a thread.
Here's an example:
This should resolve #6592, additional. I am open to adjustments and feedback!
Status and versioning classification: