Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add new activity flags #6699

Merged
merged 1 commit into from Nov 1, 2021
Merged

feat: add new activity flags #6699

merged 1 commit into from Nov 1, 2021

Conversation

almeidx
Copy link
Member

@almeidx almeidx commented Sep 27, 2021 •
edited

Please describe the changes this PR makes and why it should be merged:

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@SpaceEEC SpaceEEC changed the title feat: added new activity types feat: add new activity flags Sep 27, 2021
@kyranet kyranet added this to the Version 13.2 milestone Sep 28, 2021
SpaceEEC
SpaceEEC approved these changes Oct 3, 2021
View reviewed changes
Copy link
Member

@SpaceEEC SpaceEEC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
This probably should however not be merged until the upstream PR has been merged.

@iCrawl iCrawl modified the milestones: Version 13.2, Version 13.3 Oct 4, 2021
@iCrawl iCrawl modified the milestones: Version 13.3, Version 13.4 Oct 28, 2021
@iCrawl iCrawl merged commit 47d74eb into discordjs:main Nov 1, 2021
@almeidx almeidx deleted the activity-types branch November 1, 2021 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl iCrawl approved these changes

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

Assignees
No one assigned
Labels
api support discord semver:minor
Projects
discord.js
Archived in project
Milestone
Version 13.4
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@almeidx @vladfrangu @iCrawl @kyranet @SpaceEEC