Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(PartialGroupDMChannel): Add recipients & fix name #6713

Merged
merged 3 commits into from Oct 2, 2021

Conversation

Jiralite
Copy link
Member

Please describe the changes this PR makes and why it should be merged:

  • Added recipients (array of objects consisting of only usernames)
  • Name is null when a group direct message channel does not yet have a name (initially created)

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

@ImRodry
Copy link
Contributor

ImRodry commented Sep 29, 2021

How do you obtain this object? Also wouldn’t the name be the preset name consisting of the names of the recipients separated by commas?

@Jiralite
Copy link
Member Author

Jiralite commented Sep 29, 2021

How do you obtain this object?

  1. Create a group direct message channel
  2. Create an invite to it
  3. Client#fetchInvite

Also wouldn’t the name be the preset name consisting of the names of the recipients separated by commas?

Whilst the client shows the names of the people in the group direct message or "Unnamed" if you are alone, Discord sends null.

@iCrawl iCrawl merged commit 2803db6 into discordjs:main Oct 2, 2021
@Jiralite Jiralite deleted the name branch October 2, 2021 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants