Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Message): avoid overwriting properties in _patch #6738

Merged
merged 4 commits into from Oct 3, 2021

Conversation

SpaceEEC
Copy link
Member

@SpaceEEC SpaceEEC commented Oct 1, 2021

Please describe the changes this PR makes and why it should be merged:

This PR fixes #6431 and maybe also fixes #6368 by only updating properties if they are part of the payload.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

src/structures/Message.js Show resolved Hide resolved
src/structures/Message.js Show resolved Hide resolved
src/structures/Message.js Show resolved Hide resolved
typings/index.d.ts Outdated Show resolved Hide resolved
@iCrawl
Copy link
Member

iCrawl commented Oct 3, 2021

This needs a rebase.

@iCrawl iCrawl merged commit a8c21cd into discordjs:main Oct 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants