Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(VoiceState): Patch streaming value #6747

Merged
merged 1 commit into from Oct 3, 2021
Merged

fix(VoiceState): Patch streaming value #6747

merged 1 commit into from Oct 3, 2021

Conversation

Jiralite
Copy link
Member

@Jiralite Jiralite commented Oct 3, 2021

Please describe the changes this PR makes and why it should be merged:
This fixes a regression from #6694: Discord sends self_stream, not self_streaming. This resulted in this property always being null.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

ImRodry
ImRodry approved these changes Oct 3, 2021
View reviewed changes
Copy link
Contributor

@ImRodry ImRodry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oopsie, got confused with the streaming property 😅

@kyranet kyranet requested a review from iCrawl October 3, 2021 20:31
@kyranet kyranet added this to the Version 13.2 milestone Oct 3, 2021
@iCrawl iCrawl merged commit 7eec061 into discordjs:main Oct 3, 2021
@Jiralite Jiralite deleted the stream-fix branch October 3, 2021 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl iCrawl approved these changes

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

@ImRodry ImRodry ImRodry approved these changes

Assignees
No one assigned
Labels
bug semver:patch
Projects
None yet
Milestone
Version 13.2
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Jiralite @vladfrangu @iCrawl @kyranet @SpaceEEC @ImRodry