fix(User): compare flags in #equals #6750
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
This PR compares the users' flags in User#equals. I had to create a new _equals method to be used in actions as these compare a user object with an API user, which does not have the same properties as a Discord.js User and thus would always return false when used this way. This wasn't necessarily needed as the user update action compares 2 User objects, but it's better than having broken code. Alternatively we can drop the checks on the GuildMemberUpdate and PresenceUpdate actions and this function won't be needed, let me know what you prefer
Status and versioning classification: