fix(GuildMember): more explicit partial check #6760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckohen
force-pushed
the
fix-member-partial
branch
from
6eb9f9e
to
7005fa9
Compare
kyranet
approved these changes
Oct 5, 2021
iCrawl
approved these changes
Oct 5, 2021
vladfrangu
previously requested changes
Oct 5, 2021
ckohen
force-pushed
the
fix-member-partial
branch
from
7005fa9
to
a3ca8eb
Compare
SpaceEEC
approved these changes
Oct 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
As of discord/discord-api-docs#2911 the
joined_atproperty in GMU events can be null. Therefore the partial check was inaccurate as it relied on the truthiness ofjoinedTimestamp, of which 0 = false.This change is not breaking since
joinedAtwas already documented as nullableNote: I can't seem to get an event to fire with
joined_at: nullat all.Status and versioning classification: